Skip to content

🎨 [Frontend] Handle LongRunningTask errors better #6485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 2, 2024
Merged

🎨 [Frontend] Handle LongRunningTask errors better #6485

merged 8 commits into from
Oct 2, 2024

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 2, 2024 •
edited
Loading

What do these changes do?

  • Display error message provided by the backend
  • Show "No message" text if the flash message is empty

ErrorMessage

Related issue/s

follows #6444

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 2, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 2, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 2, 2024
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Handle 5xx errors better 🎨 [Frontend] Handle LongRunningTask errors better Oct 2, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 2, 2024 11:46
@odeimaiz odeimaiz enabled auto-merge (squash) October 2, 2024 11:53
GitHK
GitHK approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the video attached to the PR, are you using the latest version of the stack, including #6444 ? In theory, after that commit, unhandled exceptions are transformed into 500 with json-response as

{
  "error": {
      "status": 500, 
      "message": "We apologize for the inconvenience. Our team has recorded the issue and is working to resolve it as quickly as possible. Thank you for your patience [OEC: 1234]"
   }
}

and on the web-server logs you should get a comprehensive log with details of the exception including the context

@odeimaiz
Copy link
Member Author

odeimaiz commented Oct 2, 2024

In the video attached to the PR, are you using the latest version of the stack, including #6444 ? In theory, after that commit, unhandled exceptions are transformed into 500 with json-response as

{
  "error": {
      "status": 500, 
      "message": "We apologize for the inconvenience. Our team has recorded the issue and is working to resolve it as quickly as possible. Thank you for your patience [OEC: 1234]"
   }
}

and on the web-server logs you should get a comprehensive log with details of the exception including the context

Nope, the commit wasn't in yet.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit cd50cbe into ITISFoundation:master Oct 2, 2024
51 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 4, 2024
Closed
16 tasks
@pcrespov pcrespov mentioned this pull request Oct 8, 2024
Closed
1 task
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 14, 2024
@odeimaiz @mrnicegyu11
🎨 [Frontend] Handle LongRunningTask errors better (ITISFoundation#6485)
0f1ef1d
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK approved these changes

@ignapas ignapas Awaiting requested review from ignapas

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

+1 more reviewer

@jsaq007 jsaq007 jsaq007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@odeimaiz odeimaiz

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Milestone

MartinKippenberger

Development

Successfully merging this pull request may close these issues.

4 participants

@odeimaiz @jsaq007 @GitHK @pcrespov